This is a version of the life story of George M Cohan as vaudeville star, song writer, dancer and theatre producer. The film includes some of most famous songs (Yankee Doodle Boy, Give My Regards To Broadway, Over There). To modern audiences it is nationalistic, flag waving. What makes the film is the performance of James Cagney as he becomes George M Cohan, particularly in the song and dance routines. Worth watching for his performance for which James Cagney got his only Oscar win for Best Actor.